Properly pack multisig metadata and compute checkpoint digest #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
yorhodes
commented
Dec 13, 2022
•
yorhodes
commented
- Import bytes_extended and pack metadata
- fixes Solidity-compatible checkpoint digest in MultisigIsm #21
yorhodes
force-pushed
the
yorhodes/multisig-ism
branch
from
6b4dbcf
to
c6aac86
Compare
tkporter
reviewed
Dec 15, 2022
yorhodes
force-pushed
the
yorhodes/packed-ism-metadata
branch
from
c15266d
to
c32d57a
Compare
yorhodes
commented
Dec 16, 2022
Comment on lines
+387
to
+388
| // Write 32 | ||
| offset = _self.write_u16(offset, 32u16); |
There was a problem hiding this comment.
@tkporter this might be wrong actually, we need to write the bytes separately?
yorhodes
added a commit
that referenced
this pull request
Apr 6, 2023
* Add EncodedMessage * Properly pack multisig metadata and compute checkpoint digest (#26) * Use packed bytes encoding * Multisig ISM metadata tests (#32) * Don't copy / allocate new bytes in read_bytes (#34) * Move away from using the stack in favor of using structs to get references of non-reference types (#27) * Add domain hash tests * Add checkpoint hash tests * Add tests for enroll validators * Build compact signatures in tests * Verify 32 random messages in multisig tests * Add negative test cases to verify --------- Co-authored-by: Trevor Porter <trkporter@ucdavis.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.