feat: Introduce gRPC over Windows named pipes for platform parity #2491
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Amit Kumar (amitami2) <amitami2@cisco.com>
Signed-off-by: Amit Kumar (amitami2) <amitami2@cisco.com>
Signed-off-by: Amit Kumar (amitami2) <amitami2@cisco.com>
hackeramitkumar
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Tonic is widely adopted across many open-source projects for gRPC, and AGNTCY/slim also relies on Tonic for its gRPC implementation. Initially, SLIM supported gRPC communication only over TCP sockets. More recently, we added support for gRPC over Unix Domain Sockets (UDS) on Unix-based systems.
However, on Windows platforms, Tonic currently does not support gRPC over named pipes, which limits parity with Unix-based transports. This PR introduces an implementation to enable gRPC over Windows named pipes in Tonic.
Once this functionality is merged into Tonic, AGNTCY/slim will be able to add native support for gRPC over Windows named pipes as well, bringing feature parity across platforms and improving the Windows developer experience.