feat(tls): Add tls handshake timeout support #2073
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
honsunrise
force-pushed
the
feat/tls-timeout
branch
4 times, most recently
from
3e6203d to
c7297aa
Compare
honsunrise
force-pushed
the
feat/tls-timeout
branch
from
c7297aa to
9b0d570
Compare
honsunrise
force-pushed
the
feat/tls-timeout
branch
2 times, most recently
from
8b5a46b to
3ad4f97
Compare
Implement timeout controls in the TLS connection process to prevent the client from getting stuck due to the server becoming unresponsive while handling TLS. Refs: hyperium#2072
honsunrise
force-pushed
the
feat/tls-timeout
branch
from
3ad4f97 to
1d1dea5
Compare
Contributor
|
Wow, thank you! This aligns closely with what we've been observing recently. @tottoto, could you take a look at this? I believe this issue deserves more attention, as it seems that if something goes wrong during the TLS connection, the client could hang indefinitely. |
LucioFranco
approved these changes
Jun 20, 2025
Member
|
@honsunrise are you able to resolve the conflicts and we can get this merged? I am going to close it for now but if you want to pick that work up feel free to reopen (or anyone can open a new PR as well). |
Contributor
Author
|
I resolve the conflicts. But I don't know how to reopen the PR. There might be some restrictions preventing me from reopening this PR, so I've created a new one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impl: #2072