chore(ci): Switch to use GitHub Action for cargo-deny #201
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This upgrades CI from manually downloading cargo-deny to use our new cargo-deny GitHub Action.
Includes a lot of fixes, upgrades a new features as it brings cargo-deny from 0.4.0 to 0.5.2. List of changes:
https://github.com/EmbarkStudios/cargo-deny/releases
Biggest one here is that it will now also check the RUSTSEC security advisory database and will (by default) fail builds if any security advisories are detected for used crates
I was thinking first that we should wait until we have a v1 of the action and cargo-deny before using it, but as
tonic
is one of the first non-Embark repos usingcargo-deny
I think we can switch to the action here - but monitor how it works. Can always pin the action to an exact version also and/or disable advisories or other features.cc @Jake-Shadle @LucioFranco