Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(examples): Remove tracing-attributes from dependencies #1289

Merged
merged 1 commit into from
Feb 23, 2023
Merged

chore(examples): Remove tracing-attributes from dependencies #1289

merged 1 commit into from
Feb 23, 2023

Conversation

tottoto
Copy link
Collaborator

@tottoto tottoto commented Feb 21, 2023

Motivation

Simplifies examples.

Solution

We could use tracing::instrument as in the server.

LucioFranco
LucioFranco approved these changes Feb 22, 2023
View reviewed changes
Copy link
Member

@LucioFranco LucioFranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@LucioFranco LucioFranco added this pull request to the merge queue Feb 23, 2023
Merged via the queue into hyperium:master with commit 1547f96 Feb 23, 2023
@tottoto tottoto deleted the remove-tracing-attributes-from-examples branch February 23, 2023 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LucioFranco LucioFranco LucioFranco approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tottoto @LucioFranco