Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(examples): Remove unnecessary asyncronous file io to read data for example #1219

Conversation

tottoto
Copy link
Collaborator

@tottoto tottoto commented Jan 6, 2023

Motivation

Simplifies examples.

Solution

Uses the standard library to read data for examples instead of tokio's file api. In our examples we don't need to read the data asynchronously.

@tottoto tottoto changed the title chore(examples) Remove unnecessary asyncronous file io to read exampl… chore(examples): Remove unnecessary asyncronous file io to read exampl… Jan 6, 2023
@tottoto tottoto force-pushed the remove-asyncronous-file-io-from-examples branch from e289c8c to 5ef48c9 Compare January 6, 2023 10:35
@tottoto tottoto changed the title chore(examples): Remove unnecessary asyncronous file io to read exampl… chore(examples): Remove unnecessary asyncronous file io to read data for example Jan 6, 2023
@LucioFranco LucioFranco merged commit 2ec0f87 into hyperium:master Jan 6, 2023
@tottoto tottoto deleted the remove-asyncronous-file-io-from-examples branch January 7, 2023 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants