Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Use baptiste0928/cargo-install@v1 to install cargo-hack #1198

Conversation

tottoto
Copy link
Collaborator

@tottoto tottoto commented Dec 16, 2022

In every check ci jobs, it takes about 3 (in ubuntu-latest), 4 (in windows-latest), 5 (in macOS-latest) minutes to install cargo-hack. This pull request tries to speed up the jobs by introducing baptiste0928/cargo-install action using cache.

Copy link
Member

@LucioFranco LucioFranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious what is the benefit of using this action over what we had before?

@tottoto
Copy link
Collaborator Author

tottoto commented Dec 16, 2022

Once we installed cargo-hack, we can use the cached cargo-hack in the next job. So we'll be able to spare time to install cargo-hack taking up to about 5 minutes every time.

@LucioFranco LucioFranco merged commit d9578d7 into hyperium:master Dec 19, 2022
@LucioFranco
Copy link
Member

makes sense to me!

@tottoto tottoto deleted the use-cargo-install-action-to-install-cargo-hack branch December 19, 2022 19:20
@tottoto tottoto restored the use-cargo-install-action-to-install-cargo-hack branch December 19, 2022 19:20
@tottoto tottoto deleted the use-cargo-install-action-to-install-cargo-hack branch December 19, 2022 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants