-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add clippy to ci #1189
chore: Add clippy to ci #1189
Conversation
I am almost more inclined to not include clippy in ci but to accept clippy PRs as them come. Mostly this is due to my frustrations of new versions of clippy adding new lints such that it blocks PRs that add unrelated things. |
That makes sense. I understand your point and agree with you. So how do you think about lock the clippy version to the msrv for minimal lint (if it is feasable). Is it acceptable? |
I'll try to implement it. |
This reverts commit 8eaddbc.
Yeah, I am ok to lock the clippy version so that new code get caught but old code doesn't cause issues when a new version comes out. |
on a sidenote are you on discord in the tokio server? |
I have to fix this warning.
|
Ignores unknown lints and makes job fail when clippy reports warnings. |
Done. I think this is ready to be reviewed. |
I'm not on there. |
Adds clippy check to ci.