Conversation
|
I am almost more inclined to not include clippy in ci but to accept clippy PRs as them come. Mostly this is due to my frustrations of new versions of clippy adding new lints such that it blocks PRs that add unrelated things. |
|
That makes sense. I understand your point and agree with you. So how do you think about lock the clippy version to the msrv for minimal lint (if it is feasable). Is it acceptable? |
|
I'll try to implement it. |
This reverts commit 8eaddbc.
|
Yeah, I am ok to lock the clippy version so that new code get caught but old code doesn't cause issues when a new version comes out. |
|
on a sidenote are you on discord in the tokio server? |
|
I have to fix this warning. |
|
Ignores unknown lints and makes job fail when clippy reports warnings. |
|
Done. I think this is ready to be reviewed. |
I'm not on there. |
Adds clippy check to ci.