Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Bump msrv to 1.60 #1171

Merged
merged 2 commits into from
Dec 1, 2022
Merged

chore: Bump msrv to 1.60 #1171

merged 2 commits into from
Dec 1, 2022

Conversation

tottoto
Copy link
Collaborator

@tottoto tottoto commented Nov 29, 2022 •
edited
Loading

Tonic's msrv might be 1.60 due to axum 0.6.

@davidpdrsn
Copy link
Member

Oh yes thats. I forgot that axum 0.6 increased the MSRV to 1.60.

@LucioFranco
Copy link
Member

We need a msrv ci test as well. @tottoto would you be interested in adding that?

@tottoto tottoto force-pushed the bump-msrv-to-1.60 branch 3 times, most recently from de4e4a8 to cb436d6 Compare November 30, 2022 22:13
@tottoto
Copy link
Collaborator Author

tottoto commented Nov 30, 2022

I ported msrv test from hyper.

LucioFranco
LucioFranco approved these changes Dec 1, 2022
View reviewed changes
Copy link
Member

@LucioFranco LucioFranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@LucioFranco LucioFranco merged commit f7499c8 into hyperium:master Dec 1, 2022
@tottoto tottoto deleted the bump-msrv-to-1.60 branch December 1, 2022 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LucioFranco LucioFranco LucioFranco approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tottoto @davidpdrsn @LucioFranco