Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update cargo-deny config #1169

Merged
merged 4 commits into from
Dec 6, 2022

Conversation

tottoto
Copy link
Collaborator

@tottoto tottoto commented Nov 29, 2022

Updates it to support current project status.

@LucioFranco
Copy link
Member

I believe the deny check isn't running in CI, we should probably fix that if we want to keep this up to date.

@tottoto
Copy link
Collaborator Author

tottoto commented Nov 29, 2022

Fixed it. However I noticed that tonic depends on MPL-2.0 because of webpki-roots. It is a copyleft license. Should it be allowed to be used in tonic?

@LucioFranco
Copy link
Member

Yeah, we can allow it.

@LucioFranco
Copy link
Member

Though, why is the CI not failing for the copyleft? I don't think we need to explicitly allow it if CI is passing?

@tottoto
Copy link
Collaborator Author

tottoto commented Dec 6, 2022

The copyleft licenses seem to be warned as default. I added copyleft = "deny" config to make the cargo-deny job fail due to MPL-2.0 in 8e7a949 (the failed ci), and allowed it explicitly in ea3a714.

@LucioFranco
Copy link
Member

Thank you!

@LucioFranco LucioFranco merged commit d00fd08 into hyperium:master Dec 6, 2022
@tottoto tottoto deleted the update-cargo-deny-config branch December 6, 2022 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants