refactor(examples): extract Http::new outside loops
#3001
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Update: rebased onto the latest |
|
Closing due to #3013. Will definitely try again once the new API is stabilized. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello there! Now that #2321 has been resolved, I wanted to improve the documentation for the low-level server API. In all examples, I've noticed that the
Http::newfunction is repeatedly called in loops. I figured that it would be more efficient to extract theHttpinstance (out of the loop) sinceserve_connectiontakes&selfanyway (i.e., no mutability necessary). I have also updated the benches and documentation accordingly.P.S. Thanks for the shoutout at curl-up 2022! 🎉