Skip to content

Don't use Show to write UserAgent header #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 12, 2015
Merged

Don't use Show to write UserAgent header #241

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions src/header/common/user_agent.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
use header::{Header, HeaderFormat};
use std::fmt::{self, Show};
use std::fmt;
use header::shared::util::from_one_raw_str;

/// The `User-Agent` header field.
Expand All @@ -22,10 +22,16 @@ impl Header for UserAgent {

impl HeaderFormat for UserAgent {
fn fmt_header(&self, fmt: &mut fmt::Formatter) -> fmt::Result {
let UserAgent(ref value) = *self;
value.fmt(fmt)
fmt.write_str(&*self.0)
}
}

bench_header!(bench, UserAgent, { vec![b"cargo bench".to_vec()] });

#[test] fn test_format() {
use std::borrow::ToOwned;
use header::Headers;
let mut head = Headers::new();
head.set(UserAgent("Bunnies".to_owned()));
assert!(head.to_string() == "User-Agent: Bunnies\r\n".to_owned());
}