Skip to content

Feature flags: server-auto should imply server #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 17, 2023
Merged

Feature flags: server-auto should imply server #57

merged 1 commit into from
Nov 17, 2023

Conversation

@LukeMathWalker
Copy link
Contributor

As it currently stands, enabling server-auto doesn't actually give you access to any new item unless you also enable the server feature.
Considering how the code is structured, I think that the server-auto feature flag should imply the server feature flag.

seanmonstar
seanmonstar approved these changes Nov 17, 2023
View reviewed changes
Copy link
Member

@seanmonstar seanmonstar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, that's how it should be. Just like client-legacy enables client. I wrote the wrong thing. Thanks!

@seanmonstar seanmonstar merged commit f1ddfb1 into hyperium:master Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@seanmonstar seanmonstar seanmonstar approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@LukeMathWalker @seanmonstar