Repository navigation
Allow using match with Scheme #789
Description
Activity
Somewhat related but I also noticed that since the struct doesn't have
PartialEqor similar, scheme can't be used inmatch. I guess this type may be a bit old compared to other ones in the crate.Without using match, it seems we have to use if/else with dereferencing like this.
if *scheme == uri::Scheme::HTTP { self.set_item(key, intern!(py, "http"))?; } else if *scheme == uri::Scheme::HTTPS { self.set_item(key, intern!(py, "https"))?; } else { self.set_item(key, scheme.as_str())?; }
There's
TryFrom<&[u8]> for Schemewhich would do that you want.As for the match part, the hard thing is that schemes are consider case-insensitive, but
Schemedoesn't force the bytes to lower case, soPartialEqis not able to derive a byte-equivalency.- changed the title
[-]Add Scheme::from_bytes (and any others as needed)[/-][+]Allow using match with Scheme[/+]on Oct 30, 2025 Thanks @seanmonstar - I had missed
TryFromthat works well.I renamed the issue to focus on match - do you think it would make sense to have Scheme force the bytes to lower case to support match? In practice, I would be surprised if it causes allocations in any real code, i.e. there are actually non-lowercase schemes being parsed.
While working with the crate, I noticed that many types like
Method,HeaderNameand others havefrom_bytes, butSchemeonly hasfrom_str. Would it make sense to addfrom_bytesfor consistency with the others? Personally my use case is parsing a scheme from[u8]. Luckily there are only two schemes so I canmatchmyself and this isn't really tedious but wondering if it could make sense from a consistency perspective.