perf(util): optimize <BufList as Buf>::has_remaining
#94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows short-circuiting when there is a non-empty chunk.
tesaguri
force-pushed
the
buf-list-has-remaining
branch
from
10a9f72
to
22e6876
Compare
|
The CI failure doesn't seem to be relevant to this patch. |
seanmonstar
approved these changes
Feb 21, 2024
|
Could we have a release for this? |
|
I checked the benchmarks and didn't see much difference with this. But I've filed #112 which does help a lot. |
|
For me, that change was a big improvement: tokio-rs/axum#2381 (reply in thread) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows short-circuiting when there is a non-empty chunk.