Migrate to GitHub Actions #81
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanmonstar
reviewed
Feb 15, 2021
.github/workflows/ci.yml
Outdated
|
|
||
| steps: | ||
| - uses: actions/checkout@v2 | ||
| - uses: hecrj/setup-rust-action@v1 |
There was a problem hiding this comment.
Any reason not to use actions-rs/..?
There was a problem hiding this comment.
Sorry, for being 🦥 . I've updated the PR comment.
|
Thanks for explaining some. The reason I ask is that unless there's a significant reason otherwise, it makes sense to me to keep things similar across hyper, h2, http, etc. Does that seem reasonable? Is there places in the Rust ecosystem that are shifting from |
|
I think the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reason to choose
setup-rust-actionoveraction-rs/*is that the action already comes with problem matchers for error, warning & cargo. This makesactions-rs/cargoobsolete and the workflow less verbose.