Expose the Accept header #51
Conversation
|
Thanks for the PR! The |
src/common/accept.rs
Outdated
| /// ); | ||
| /// ``` | ||
| #[derive(Debug, PartialEq, Eq)] | ||
| pub struct Accept(pub Vec<QualityValue<Mime>>); |
There was a problem hiding this comment.
This crate has tried to be very conservative in what details it exposes, to try to allow the internal representations to change without it being a breaking change. So at the very least, I'd keep the fields private.
| @@ -33,21 +32,18 @@ impl Default for Quality { | |||
|
|
|||
| /// Represents an item with a quality value as defined in | |||
| /// [RFC7231](https://tools.ietf.org/html/rfc7231#section-5.3.1). | |||
| #[derive(Clone, PartialEq, Debug)] | |||
| #[derive(Clone, PartialEq, Eq, Debug)] | |||
| pub struct QualityValue<T> { | |||
There was a problem hiding this comment.
I've felt for a while now that the QualityValue design is kind of annoying to use, but I've never sat down to come up with a better one.
There was a problem hiding this comment.
Can't say I have any better idea. The API looks ok to me, at least there isn't anything that should be clearly removed
|
Is there anything blocking this PR from getting merged? |
|
bumping interest in this PR, or at least interest in having the accept header available |
Enables
Acceptwithout any deeper changes and exposes the internalMethodofAccessControlRequestMethod. Probably a better way of doing this PR but this adds the features I need to migrate from https://github.com/dekellum/hyperx