Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/client.rs
Original file line number Diff line number Diff line change
Expand Up @@ -923,7 +923,7 @@ impl Builder {
/// received for that stream will result in a connection level protocol
/// error, forcing the connection to terminate.
///
/// The default value is 10.
/// The default value is currently 50.
///
/// # Examples
///
Expand Down Expand Up @@ -968,7 +968,7 @@ impl Builder {
/// received for that stream will result in a connection level protocol
/// error, forcing the connection to terminate.
///
/// The default value is 30 seconds.
/// The default value is currently 1 second.
///
/// # Examples
///
Expand Down
8 changes: 6 additions & 2 deletions src/proto/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,10 @@ pub type WindowSize = u32;
pub const MAX_WINDOW_SIZE: WindowSize = (1 << 31) - 1; // i32::MAX as u32
pub const DEFAULT_REMOTE_RESET_STREAM_MAX: usize = 20;
pub const DEFAULT_LOCAL_RESET_COUNT_MAX: usize = 1024;
pub const DEFAULT_RESET_STREAM_MAX: usize = 10;
pub const DEFAULT_RESET_STREAM_SECS: u64 = 30;
// RFC 9113 suggests allowing at minimum 100 streams, it seems reasonable to
// by default allow a portion of that to be remembered as reset for some time.
pub const DEFAULT_RESET_STREAM_MAX: usize = 50;
// RFC 9113#5.4.2 suggests ~1 RTT. We don't track that closely, but use a
// reasonable guess of the average here.
pub const DEFAULT_RESET_STREAM_SECS: u64 = 1;
pub const DEFAULT_MAX_SEND_BUFFER_SIZE: usize = 1024 * 400;
8 changes: 6 additions & 2 deletions src/proto/streams/recv.rs
Original file line number Diff line number Diff line change
Expand Up @@ -912,11 +912,15 @@ impl Recv {
return;
}

tracing::trace!("enqueue_reset_expiration; {:?}", stream.id);

if counts.can_inc_num_reset_streams() {
counts.inc_num_reset_streams();
tracing::trace!("enqueue_reset_expiration; added {:?}", stream.id);
self.pending_reset_expired.push(stream);
} else {
tracing::trace!(
"enqueue_reset_expiration; dropped {:?}, over max_concurrent_reset_streams",
stream.id
);
}
}

Expand Down
4 changes: 2 additions & 2 deletions src/server.rs
Original file line number Diff line number Diff line change
Expand Up @@ -868,7 +868,7 @@ impl Builder {
/// received for that stream will result in a connection level protocol
/// error, forcing the connection to terminate.
///
/// The default value is 10.
/// The default value is currently 50.
///
/// # Examples
///
Expand Down Expand Up @@ -993,7 +993,7 @@ impl Builder {
/// received for that stream will result in a connection level protocol
/// error, forcing the connection to terminate.
///
/// The default value is 30 seconds.
/// The default value is currently 1 second.
///
/// # Examples
///
Expand Down