Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade tokio-util to 0.7 #603

Merged
merged 1 commit into from
Mar 29, 2022
Merged

Conversation

djc
Copy link
Contributor

@djc djc commented Feb 11, 2022

No description provided.

@olix0r
Copy link
Collaborator

olix0r commented Feb 11, 2022

I'm not sure why the nightly build failed but it looks like it's picking up a very old tokio version:

Compiling tokio v1.0.1

@djc
Copy link
Contributor Author

djc commented Feb 11, 2022

That's because it's the cargo update -Zminimal-versions step of the CI build. I already asked on the Tokio Discord about this, we should likely get a new tokio-util that fixes the minimal version of Tokio that it needs.

@olix0r
Copy link
Collaborator

olix0r commented Feb 18, 2022

We could probably unblock this by specifying the minimum working version in h2's Cargo.toml:

h2/Cargo.toml

Line 47 in 4c31a32

tokio = { version = "1", features = ["io-util"] }

@djc
Copy link
Contributor Author

djc commented Feb 21, 2022

I submitted tokio-rs/tokio#4521 to try and get a tokio-util 0.7.1 out.

Cargo.toml Outdated Show resolved Hide resolved
@djc
Copy link
Contributor Author

djc commented Mar 29, 2022

@paolobarbolini thanks for the reminder! I think this could be merged now.

@seanmonstar seanmonstar merged commit a54d926 into hyperium:master Mar 29, 2022
@paolobarbolini
Copy link
Contributor

Could we get a new release with this @seanmonstar? I'd love not having to live with duplicate dependency versions in my dependency tree

@seanmonstar
Copy link
Member

Published: https://github.com/hyperium/h2/releases/tag/v0.3.13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants