Effect not suspended when instance is stopped

[esdeboer]

• I confirm that this is an issue rather than a question.

Bug report

Suspending or stopping an instance does not seem to stop the effect running (CPU usage only goes down to 0 after I stop the effect, not on stopping the LED instance)

Steps to reproduce

Run an effect on a LED instance and stop the instance.
Observe Hyperion still uses quite a bit CPU.
Remove the effect.
Observe Hyperion does not use CPU anymore.

What is expected?

Hyperion CPU usage will be near 0 on suspension.

What is actually happening?

CPU usage stays high.
Also disabling an LED instance while an effect is running seems to create a memory leak (seems I run out of memory after a few weeks since I'm disabling the instance instead of stopping the effect).

System

Hyperion Server:

• Build: (HEAD detached at 2.0.15) (GitHub-70e1043/24a00e3-1676809483)
• Build time: Feb 19 2023 16:07:11
• Git Remote: https://github.com/hyperion-project/hyperion.ng
• Version: 2.0.15
• UI Lang: en (BrowserLang: en-US)
• UI Access: default
• Avail Screen Cap.: dispmanx,framebuffer,qt
• Avail Video Cap.: v4l2
• Avail Audio Cap.: audio
• Avail Services: boblight,cec,effectengine,forwarder,flatbuffer,protobuffer,mDNS,SSDP,borderdetection
• Config path: /home/pi/.hyperion
• Database: read/write

Hyperion Server OS:

• Distribution: Raspbian GNU/Linux 11 (bullseye)
• Architecture: arm
• CPU Model: ARMv6-compatible processor rev 7 (v6l)
• CPU Type: Raspberry Pi Model B Rev 2
• CPU Revision: 000e
• CPU Hardware: BCM2835
• Kernel: linux (5.15.76+ (WS: 32))
• Root/Admin: false
• Qt Version: 5.15.2
• Python Version: 3.9.2
• Browser: Mozilla/5.0 (X11; Linux x86_64; rv:109.0) Gecko/20100101 Firefox/109.0