This repository was archived by the owner on Feb 8, 2021. It is now read-only.
double confirm the process has already been started #286
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jenkins failed due to the serial port breaking issue. retest this please, hykins |
gnawux
changed the title
|
both jenkins and one job of travis failed due to hyperhq/hyperd#555 , wonder if this patch increases its hit probability. |
laijs
reviewed
Apr 5, 2017
src/exec.c
Outdated
| @@ -563,9 +563,14 @@ static void hyper_exec_process(struct hyper_exec *exec, struct stdio_config *io) | |||
|
|
|||
| setsid(); | |||
|
|
|||
| if (pipe > 0) { | |||
laijs
reviewed
Apr 5, 2017
src/exec.c
Outdated
| @@ -563,9 +563,14 @@ static void hyper_exec_process(struct hyper_exec *exec, struct stdio_config *io) | |||
|
|
|||
| setsid(); | |||
|
|
|||
| if (pipe > 0) { | |||
| //send success notification before stdio was installed, otherwise it will be sent to user tty. | |||
There was a problem hiding this comment.
otherwise the debug log in hyper_send_type() will be sent to user tty.
laijs
reviewed
Apr 5, 2017
| } | ||
|
|
||
| //two message may come back in reversed sequence | ||
| exec->pid = (type == 0) ? cpid : type; |
There was a problem hiding this comment.
it is time for converting success-notification-pipes to eventfd....
(not reqired in this pr)
|
retest this please, hykins |
laijs
reviewed
Apr 5, 2017
src/exec.c
Outdated
| @@ -581,6 +584,10 @@ static void hyper_exec_process(struct hyper_exec *exec, struct stdio_config *io) | |||
| } | |||
|
|
|||
| exit: | |||
| if (pipe > 0) { | |||
Having sent pid, the container might have not been started well, a signal comes at this time may not take into effect. see hyperhq#285 Signed-off-by: Wang Xu <gnawux@gmail.com>
gnawux
added a commit
to gnawux/hyperstart
that referenced
this pull request
Apr 20, 2017
backport hyperhq#286 to maintenance_1 Signed-off-by: Wang Xu <gnawux@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EDIT: simplified the implementation
Having sent pid, the container might have not been started well, a signal comes at this time may not take into effect. see #285
as described in #285, looks send back pid too early may lead to a race conditionif a signal comes right after the init container request.In this commit, I try to delay sending back the pid, which is a bit complicatedbecause the pid can not get with getpid(2) in the child process as it is in a new ns.Signed-off-by: Wang Xu gnawux@gmail.com