Skip to content
This repository was archived by the owner on Feb 8, 2021. It is now read-only.

Support for deleting container #371

Closed
wants to merge 3 commits into from

Conversation

YaoZengzeng
Copy link
Contributor

No description provided.

@@ -33,3 +33,16 @@ func (s *ServerRPC) ContainerStop(c context.Context, req *types.ContainerStopReq

return &types.ContainerStopResponse{}, nil
}

// ContainerRemove implements DELETE /container
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update doc as ContainerRemove deletes the specified container

@feiskyer feiskyer added this to the v0.7.0 milestone Jun 21, 2016
@YaoZengzeng
Copy link
Contributor Author

Ready for review, after the pr of "runv #267" and "hyperstart #121" being merged.

@YaoZengzeng YaoZengzeng force-pushed the delete-container branch 3 times, most recently from 9d425a8 to fea7a1b Compare June 30, 2016 08:40
Signed-off-by: Yao Zengzeng <yaozengzeng@foxmail.com>
Signed-off-by: Yao Zengzeng <yaozengzeng@foxmail.com>
Signed-off-by: Yao Zengzeng <yaozengzeng@foxmail.com>
return fmt.Errorf("can not find container %s", containerId)
}

if !pod.TransitionLock("rm") {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pod.TransitionLock("rmContainer")

@gnawux gnawux modified the milestones: v0.8.0, v0.7.0 Dec 6, 2016
@gnawux
Copy link
Member

gnawux commented Mar 20, 2017

I think we may close this PR, remove container from pod is supported in #445 and #469

@gnawux gnawux closed this Mar 20, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants