Conversation
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
fe1f0bd to
4529973
Compare
4529973 to
18b725a
Compare
Ref: HDX-1239
18b725a to
64c8378
Compare
| expect(Number(response.body.data[0]['series_0.data'])).toEqual(1); | ||
| }); | ||
|
|
||
| it('should handle lucene query errors gracefully', async () => { |
There was a problem hiding this comment.
Should there be a corresponding test to handle sql errors - e.g. what does it return when I give it a non-sql where clause when whereLanguage == 'sql'?
|
@dhable PR updated with ur feedback and tests updated. |
Testing Notes:
It was easiest for me to go to the UI, create a new chart and grab the sourceid and start/end timestamps from the URL, plug it in and profit.
Note: It was apparent to me that we will need to provide at least GET support for sources, otherwise that ID is not easily obtained.
Ref: HDX-1651