Skip to content

feat: Improve source editing UX #805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: v2
Choose a base branch
from

Conversation

ernestii
Copy link
Contributor

@ernestii ernestii commented May 11, 2025

Background: the gear icon on the search page showed a modal for editing the source. Due to low friction and lack of context clues, it appeared as if those settings are ad-hoc for the current query.

The new UX is a dropdown with a link to the Teams page to make it clear that those are team-wide settings.

Screenshot 2025-05-10 at 8 16 24 PM

Copy link

changeset-bot bot commented May 11, 2025

⚠️ No Changeset found

Latest commit: a7adea1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented May 11, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hyperdx-v2-oss-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 21, 2025 10:25pm

<Menu.Item
leftSection={<i className="bi bi-gear" />}
component={Link}
href="/team"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a bit painful split to have but in local mode we don't have a team page to edit sources, maybe we should either keep the team page in local mode (a bit confusing?) or keep the modal here (more components to maintain just for local mode)

you can view the issue when trying to edit sources in the vercel preview of this PR

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oo good point. keeping the modal for local mode makes sense

@ernestii ernestii force-pushed the ernest/hdx-1691-prevent-source-settings-from-being-too-easily-modified branch from ec99c20 to 366b991 Compare May 15, 2025 00:08
@ernestii ernestii requested a review from MikeShi42 May 15, 2025 00:12
@teeohhem
Copy link
Contributor

@ernestii I'll review today after conflicts are resolved. Can you resolve them plz? Thanks ^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants