-
Notifications
You must be signed in to change notification settings - Fork 254
feat: Improve source editing UX #805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: v2
Are you sure you want to change the base?
feat: Improve source editing UX #805
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
packages/app/src/DBSearchPage.tsx
Outdated
<Menu.Item | ||
leftSection={<i className="bi bi-gear" />} | ||
component={Link} | ||
href="/team" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a bit painful split to have but in local mode we don't have a team page to edit sources, maybe we should either keep the team page in local mode (a bit confusing?) or keep the modal here (more components to maintain just for local mode)
you can view the issue when trying to edit sources in the vercel preview of this PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oo good point. keeping the modal for local mode makes sense
ec99c20
to
366b991
Compare
@ernestii I'll review today after conflicts are resolved. Can you resolve them plz? Thanks ^ |
…eing-too-easily-modified
Background: the gear icon on the search page showed a modal for editing the source. Due to low friction and lack of context clues, it appeared as if those settings are ad-hoc for the current query.
The new UX is a dropdown with a link to the Teams page to make it clear that those are team-wide settings.