Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update session player #395

Merged
merged 3 commits into from
May 12, 2024
Merged

fix: Update session player #395

merged 3 commits into from
May 12, 2024

Conversation

ernestii
Copy link
Contributor

@ernestii ernestii commented May 5, 2024

  • Replace react-slider with mantine's slider + custom markers for better performance
  • Fix bug when opening a session replay with a ?ts param shows the first frame instead of correct frame at ts
  • abort loading events when navigating off the page

before

Screen.Recording.2024-05-05.at.9.56.28.PM.mov

after

Screen.Recording.2024-05-05.at.9.55.04.PM.mov

Copy link

changeset-bot bot commented May 5, 2024

🦋 Changeset detected

Latest commit: 5b1c34b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@hyperdx/app Patch
@hyperdx/api Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ernestii ernestii force-pushed the ei/hdx-286 branch 4 times, most recently from 319ccf5 to 6d66145 Compare May 6, 2024 14:22
@ernestii ernestii changed the title fix: Update session player playbar fix: Update session player May 6, 2024
@ernestii ernestii requested a review from MikeShi42 May 10, 2024 21:42
@kodiakhq kodiakhq bot merged commit 6d99e3b into main May 12, 2024
4 checks passed
@kodiakhq kodiakhq bot deleted the ei/hdx-286 branch May 12, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants