Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: dense rank should be computed base on rank value and group #302

Merged
merged 2 commits into from
Feb 7, 2024
Merged

fix: dense rank should be computed base on rank value and group #302

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
12c8490
fix: dense rank should be computed base on rank value and group
wrn14897 Feb 6, 2024
435e4a5
docs: add changeset
wrn14897 Feb 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changeset/smart-squids-jog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
'@hyperdx/api': patch
'@hyperdx/app': patch
---

fix: dense rank should be computed base on rank value and group (multi-series
chart)
2 changes: 1 addition & 1 deletion packages/api/src/clickhouse/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1589,7 +1589,7 @@ export const queryMultiSeriesChart = async ({
SELECT *, ?(?) OVER (PARTITION BY group) as rank_order_by_value
FROM raw_groups
), final AS (
SELECT *, DENSE_RANK() OVER (ORDER BY rank_order_by_value ?) as rank
SELECT *, DENSE_RANK() OVER (ORDER BY rank_order_by_value ?, group) as rank
FROM groups
)
SELECT *
Expand Down
Loading