Skip to content

feat: Namespaces Tab #261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 21, 2024
Merged

feat: Namespaces Tab #261

merged 3 commits into from
Jan 21, 2024

Conversation

svc-shorpo
Copy link
Contributor

@svc-shorpo svc-shorpo commented Jan 21, 2024 •
edited
Loading

Screenshot 2024-01-20 at 10 46 14 PM

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 21, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 7c1c23d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@svc-shorpo svc-shorpo changed the title sr/namespaces tab feat: Namespaces Tab Jan 21, 2024
MikeShi42
MikeShi42 reviewed Jan 21, 2024
View reviewed changes
packages/app/src/KubernetesDashboardPage.tsx Outdated
table: 'metrics',
field: 'k8s.pod.cpu.utilization - Gauge',
type: 'table',
aggFn: 'avg',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it makes more sense to show the aggregate CPU and memory usage via a sum here

MikeShi42
MikeShi42 reviewed Jan 21, 2024
View reviewed changes
packages/app/src/KubernetesDashboardPage.tsx Outdated
table: 'metrics',
field: 'k8s.namespace.phase - Gauge',
type: 'table',
aggFn: 'avg',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we'd want to use last_value here

MikeShi42
MikeShi42 reviewed Jan 21, 2024
View reviewed changes
packages/app/src/KubernetesDashboardPage.tsx Outdated
groupBy: 'k8s.namespace.name',
where: whereClause,
table: 'metrics',
aggFn: 'avg',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here I think we'd want sum for cpu/mem

@svc-shorpo
Copy link
Contributor Author

made changes

@svc-shorpo svc-shorpo requested a review from MikeShi42 January 21, 2024 06:34
@svc-shorpo
Copy link
Contributor Author

svc-shorpo commented Jan 21, 2024 •
edited
Loading

also added namespace details panel

Screenshot 2024-01-21 at 12 02 02 AM

@svc-shorpo svc-shorpo merged commit 17e5027 into main Jan 21, 2024
@svc-shorpo svc-shorpo deleted the sr/namespaces-tab branch January 21, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MikeShi42 MikeShi42 MikeShi42 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@svc-shorpo @MikeShi42