Skip to content

Plotting #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jun 1, 2022
Merged

Plotting #67

merged 11 commits into from
Jun 1, 2022

Conversation

dheyay
Copy link
Collaborator

@dheyay dheyay commented May 26, 2022

  • Added initial functions to plot similarity matrix for basis vector set and stem plot for vector similarity

@dheyay dheyay linked an issue May 26, 2022 that may be closed by this pull request
2 tasks
@mikeheddes
Copy link
Member

Thanks for the PR. Can you move the plotting to a new module called utils? And rename visualize to plot? Can you perform the import of matplotlib inside the function and throw an informative error telling the user to install matplotlib if they wanna use this function. This will make matplotlib an optional dependency. For the API of the functions can you look at how Seaborn does it? I think they allow you to provide your own axis of the plot. And you don’t have to call show in the function. The function should return the axis like Seaborn. Thank you!

@dheyay
Copy link
Collaborator Author

dheyay commented May 27, 2022

I have changed the functions to take in the "matplotlib axes" as an optional argument and the kwargs accomodates all the other optional arguments that are passed to the underlying pyplot functions.

@mikeheddes mikeheddes merged commit c745b5c into main Jun 1, 2022
@mikeheddes mikeheddes deleted the plotting branch June 1, 2022 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add plotting
2 participants