Skip to content

Fix randsel probability is opposite of documentation #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 13, 2023

Conversation

mikeheddes
Copy link
Member

Description

Selects elements from the input tensor if p=1 and from the other tensor when p=0. Fixes #161 .

Checklist

  • I added/updated documentation for the changes.
  • I have thoroughly tested the changes.

@mikeheddes
Copy link
Member Author

While there seem to be some problems in the tests, they are due to problems with the dataset server. The tests that cover the changes are passing so I'm merging this PR.

@mikeheddes mikeheddes merged commit 535f56b into main Nov 13, 2023
@mikeheddes mikeheddes deleted the fix/randsel-prob branch November 13, 2023 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

randsel has inverted probability for input versus other selection
1 participant