Skip to content

Rewrite scope strategy #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Sep 8, 2025
Merged

Rewrite scope strategy #43

merged 6 commits into from
Sep 8, 2025

Conversation

@sebastianvarela
Copy link
Contributor

@sebastianvarela sebastianvarela commented Sep 8, 2025

PR's key points

  • Rewrite all the scope function by using a custom publisher to avoid unwanted emissions on complex states
  • Remove the publisher mode because is confusing and not necessary with the new publisher

How to review this PR?

Check the new test case thats cover the new uses cases.

@sebastianvarela sebastianvarela self-assigned this Sep 8, 2025
@sebastianvarela sebastianvarela requested a review from a team as a code owner September 8, 2025 09:36
@sebastianvarela sebastianvarela merged commit bd49bf4 into master Sep 8, 2025
@sebastianvarela sebastianvarela deleted the task/fix_scope branch September 8, 2025 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adrianrl adrianrl adrianrl approved these changes

Assignees

@sebastianvarela sebastianvarela

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sebastianvarela @adrianrl