Skip to content

Add support for keras callback #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Dec 10, 2017
Merged

Conversation

richardartoul
Copy link
Contributor

No description provided.

@richardartoul richardartoul changed the title Add support for keras callback [WIP] - Add support for keras callback Nov 20, 2017
@richardartoul richardartoul changed the title [WIP] - Add support for keras callback Add support for keras callback Nov 20, 2017
Copy link
Contributor

@andrewschreiber andrewschreiber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Will be great for our Keras users.

# 2) on_batch_begin
# 3) on_batch_end
# 4) on_train_begin
# 5) on_train_end
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think on_train_end will be key for knowing when the run ends, true?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nah we know that already cause the user's program exits

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(or they call exp.end()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants