Skip to content

Write Stream error not propagated #9

@pfrazee

Description

@pfrazee

I found that if a createWriteStream() call was creating an error, the error wasn't getting pushed into the writestream. (I'm not 100% sure where the error was occurring, possibly in GRPC's encoding because it was some assertionerror.)

What I found was with https://github.com/andrewosh/hyperdrive-daemon-client/blob/master/index.js#L491 this line, if I removed the return and allowed the callback to be called, the error would correctly propagate. Any chance that's the correct behavior?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions