Implement contract signature verification #238
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To support filecoin we need to bypass the SafeSDK to verify Safe signatures. The SafeSignatureVerifier class was updated to support different strategies based on chain ID. A SignatureVerifierFactory was implemented to either execute a contract call or use the Safe SDK depending on the provided chain ID.
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||
pheuberger
reviewed
Feb 4, 2025
| } | ||
|
|
||
| export class SignatureVerifierStrategyFactory { | ||
| static getStrategy( |
There was a problem hiding this comment.
Since choosing the strategy isn't influenced by the hash of the typed data, I feel like it shouldn't be here. It also doesn't necessarily need to be on the constructor if the other fields aren't either. From the viewpoint of the individual classes you can't necessarily say that the hash is a value that you would want to keep across multiple invocations, so the actual call to verify() seems like it's lacking this value.
It's absolutely fine the way it is, but would probably be something that I'd refactor given I have the time and am working on something that's touching this code :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To support filecoin we need to bypass the SafeSDK to verify Safe signatures. The SafeSignatureVerifier class was updated to support different strategies based on chain ID. A SignatureVerifierFactory was implemented to either execute a contract call or use the Safe SDK depending on the provided chain ID.