Merged
Conversation
severo
approved these changes
Nov 29, 2025
Contributor
severo
left a comment
severo
left a comment
There was a problem hiding this comment.
I don't remember why. I'll investigate more on Monday.
Contributor
|
The only previous change was: 7fb7a4b#diff-3ae20d611c1c7263a9c1bce0449291ebfea1c5d578b3fcdbb596353ad885db25. |
Contributor
Author
|
Hmm, my bad I guess? I don't remember why I did that, I thought I just copied from your hyparquet build file but that seems to not be the case. Probably I was trying to make the build faster? But apparently too fast :-) Unless we see problems downstream, this should be better now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Building types for publish was broken. The last version published (0.3.30) I made had no types because when I run
npm run buildI get no type files in thelibfolder.I investigated and it's because the
incrementalandcompositeoptions intsconfig.build.jsonwere causing typescript to create atsconfig.build.tsbuildinfo, and as long as that file existed, typescript would skip type creation in the lib directory.Some reading made it seem like incremental and composite are only if we're doing something with multi-project config? I removed the options changed to a non-project build. Fixed the type build issue.
Let me know if this is going to break something you did intentionally? @severo