Conversation
Merged
Contributor
Author
Contributor
|
We should also add a keyboard handler here for up/down arrow. Going down from the main button should loop through the children but not cycle back to the main button again. function handleArrowKeys(event: KeyboardEvent) {
if (isOpen && (event.key === 'ArrowDown' || event.key === 'ArrowUp')) {
event.preventDefault()
const focusableElements = menuRef.current?.querySelectorAll<HTMLElement>(
'button, [href], input, select, textarea, [tabindex]:not([tabindex="-1"])'
)
if (focusableElements && focusableElements.length > 0) {
const currentIndex = Array.from(focusableElements).indexOf(document.activeElement as HTMLElement)
let nextIndex = currentIndex
if (event.key === 'ArrowDown') {
nextIndex = (currentIndex + 1) % focusableElements.length
} else if (event.key === 'ArrowUp') {
nextIndex = (currentIndex - 1 + focusableElements.length) % focusableElements.length
}
focusableElements[nextIndex]?.focus()
}
}
} |
bleakley
approved these changes
Apr 10, 2025
Contributor
bleakley
left a comment
There was a problem hiding this comment.
Arrow key handling would be nice but not absolutely needed
bleakley
approved these changes
Apr 10, 2025
| } | ||
| } | ||
|
|
||
| function handleEscape(event: KeyboardEvent) { |
Contributor
There was a problem hiding this comment.
I don't think we need to add this escape key listener to the dropdown anymore, unless there's some tiny part of the element that's outside of the button and the content.
Contributor
Author
There was a problem hiding this comment.
if the user tabs out to another part of the page and hits escape, we should probably close the menu? leaving it for now
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a Dropdown component to the
hyperparampackage. Useful for the demos, etc.I also fixed a few random nits and upgraded the dependencies.