Merged
Conversation
4329c70 to
0fde1db
Compare
ceae0ec to
76a1f29
Compare
platypii
approved these changes
Mar 31, 2025
Contributor
platypii
left a comment
There was a problem hiding this comment.
Looks good. Splitting out smaller components seems like a good thing. The two that feel a little weird are Center and VisuallyHidden which feel more like styles than components. It good for now though. 👍
Contributor
Author
|
Re VisuallyHidden: it's a common component in any library, and is the current best practice to provide an accessible text without showing it visually (it's more accessible than For Center... I don't like it too much, either. Maybe I'll revisit if I find a better way. |
Contributor
Author
|
Also @platypii: do you have an opinion on the code structure, ie: Current: three times the same hierarchy in:
versus the proposal:
I created #189 to discuss it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #165
Sorry for the review @platypii, it's a very big PR.
I have a proposal for this PR, @platypii:
I think we could reorganize the files a bit, like I did in hightable, loosely following https://www.joshwcomeau.com/react/file-structure/:
It would help find the files quickly, and it would group the styles and components together (this PR will create many CSS module files).