Skip to content

Replace Newtonsoft.Json with System.Text.Json#1071

Draft
anthonie-kramer wants to merge 176 commits intomasterfrom
stj-2023
Draft

Replace Newtonsoft.Json with System.Text.Json#1071
anthonie-kramer wants to merge 176 commits intomasterfrom
stj-2023

Conversation

@anthonie-kramer
Copy link
Contributor

@anthonie-kramer anthonie-kramer commented Dec 7, 2023

IN PROGRESS NOTES:

  • STJ does not like abstract classes... We need more Converters to handle deserialization
  • STJ does not like methods in Constructors (neither does Newtonsoft, so I'm not sure how we get away with it now)

BACKGROUND:

  • Trying to replace Newtonsoft.Json with System.Text.Json for performance improvements

DESCRIPTION:

  • Merges Ian's previous solution (branch stj) with the most recent master branch
  • Additional Converters are required due to deeper abstractions that were added (like BoundedCurve)

TESTING:

  • Ensure that the tests in the project are passing
  • Publish a function that uses the updated Elements to ensure it works with Explore

FUTURE WORK:

  • We will also need to update CodeGen stuff
  • Update other projects that use Newtonsoft.Json

REQUIRED:

  • All changes are up to date in CHANGELOG.md.
  • This is compatible with the CLI
  • This is compatible with Explore

COMMENTS:

  • Any other notes.

This change is Reviewable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants