Skip to content
This repository was archived by the owner on May 7, 2023. It is now read-only.

Tag user List logic (add ui)#505

Closed
hankkuu wants to merge 2 commits intohyochan:masterfrom
hankkuu-mobile:feat/tag-users
Closed

Tag user List logic (add ui)#505
hankkuu wants to merge 2 commits intohyochan:masterfrom
hankkuu-mobile:feat/tag-users

Conversation

@hankkuu
Copy link

@hankkuu hankkuu commented Oct 13, 2021

Specify project

Client

Description

Show user list after input @ keyword

Related Issues

issue #473

Checklist

Before you create this PR confirms that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the [CLA].
  • Run yarn lint && yarn tsc
  • Run yarn test or yarn test -u if you need to update snapshot.
  • I am willing to follow-up on review comments in a timely manner.

@hankkuu hankkuu requested review from geoseong and hyochan October 13, 2021 13:55
@hankkuu hankkuu changed the title feat: show tagging list of users Tag user List logic (add ui) Oct 13, 2021
@codecov
Copy link

codecov bot commented Oct 13, 2021

Codecov Report

Merging #505 (b8ef55e) into master (e17eedc) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #505   +/-   ##
=======================================
  Coverage   76.09%   76.09%           
=======================================
  Files          64       64           
  Lines        1163     1163           
  Branches      130      130           
=======================================
  Hits          885      885           
  Misses        276      276           
  Partials        2        2           
Flag Coverage Δ
unittests 76.09% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e17eedc...b8ef55e. Read the comment docs.

Copy link
Owner

@hyochan hyochan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the CI by updating snapshots and re-request a review 🙏

@hyochan hyochan added the 🎯 feature New feature label Oct 14, 2021
@hyochan hyochan mentioned this pull request Oct 14, 2021
5 tasks
@hyochan
Copy link
Owner

hyochan commented Oct 14, 2021

Also you might want to give PR to #501 instead? Looks like you are working on the samething.

@hankkuu
Copy link
Author

hankkuu commented Oct 17, 2021

Also you might want to give PR to #501 instead? Looks like you are working on the samething.

yes. same #501 PR.

we will be merged all code and push PR #501 after handle some request

@whywhyy
Copy link
Contributor

whywhyy commented Oct 17, 2021

Also you might want to give PR to #501 instead? Looks like you are working on the samething.

has been merged. You can close this PR.

@hankkuu hankkuu closed this Oct 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

🎯 feature New feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments