Skip to content
This repository has been archived by the owner on May 7, 2023. It is now read-only.

Workaround for typing issue in #150 #151

Merged
merged 1 commit into from
Jul 2, 2020
Merged

Workaround for typing issue in #150 #151

merged 1 commit into from
Jul 2, 2020

Conversation

hyochan
Copy link
Owner

@hyochan hyochan commented Jul 2, 2020

Specify project

Client

Description

There is an impedance mismatch on generated typing on the QueryResponse and the User.

Related Issues

#150

Checklist

Before you create this PR confirms that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the [CLA].
  • Run yarn lint && yarn tsc
  • Run yarn test or yarn test -u if you need to update snapshot.
  • I am willing to follow-up on review comments in a timely manner.

@codecov
Copy link

codecov bot commented Jul 2, 2020

Codecov Report

Merging #151 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #151   +/-   ##
=======================================
  Coverage   65.95%   65.95%           
=======================================
  Files          22       22           
  Lines         373      373           
  Branches       25       25           
=======================================
  Hits          246      246           
  Misses        121      121           
  Partials        6        6           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9aa1d4f...3b50e18. Read the comment docs.

@hyochan
Copy link
Owner Author

hyochan commented Jul 2, 2020

Looks like there is a limitation on this situation. @smallbee3 @devethan I've made a simple workaround.

@smallbee3
Copy link
Contributor

smallbee3 commented Jul 2, 2020

Wow. I couldn't even think about this simple workaround!

@hyochan
Copy link
Owner Author

hyochan commented Jul 2, 2020

Yeah sometimes we need to relax to find a solution 😄

@hyochan hyochan merged commit f50b4fb into master Jul 2, 2020
@hyochan hyochan deleted the enh/typings branch July 2, 2020 06:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants