Skip to content
This repository has been archived by the owner on Dec 26, 2024. It is now read-only.

chore: include commitlint to handle better commit messages #206

Merged
merged 3 commits into from
Aug 6, 2022

Conversation

hyochan
Copy link
Owner

@hyochan hyochan commented Aug 6, 2022

Description

Check the commit message is valid to make the commit tree clean.

We now need to add types to commit messages.

build
chore
ci
docs
feat
fix
perf
refactor
revert
style
test

Above rule is based on angular convention.

Test Plan

Add validation to the ci step.

Related Issues

https://www.freecodecamp.org/news/how-to-use-commitlint-to-write-good-commit-messages

Tests

Passes

Checklist

Before you create this PR confirms that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • Run yarn test:all and make sure nothing fails. You can run yarn test -u to update snapshots if needed.
  • I am willing to follow-up on review comments in a timely manner.

@hyochan hyochan added 🍗 enhancement New feature or request 💨 ci Cloud integration labels Aug 6, 2022
@codecov
Copy link

codecov bot commented Aug 6, 2022

Codecov Report

Merging #206 (127bac1) into main (03ffddd) will not change coverage.
The diff coverage is n/a.

❗ Current head 127bac1 differs from pull request most recent head e326606. Consider uploading reports for the commit e326606 to get more accurate results

@@           Coverage Diff           @@
##             main     #206   +/-   ##
=======================================
  Coverage   86.41%   86.41%           
=======================================
  Files          27       27           
  Lines         714      714           
  Branches      296      296           
=======================================
  Hits          617      617           
  Misses         97       97           

@hyochan hyochan merged commit db8d944 into main Aug 6, 2022
@hyochan hyochan deleted the ci/commitlint branch August 6, 2022 10:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
💨 ci Cloud integration 🍗 enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant