Skip to content
This repository has been archived by the owner on Dec 26, 2024. It is now read-only.

Enhance CI script #132

Merged
merged 4 commits into from
Sep 28, 2021
Merged

Enhance CI script #132

merged 4 commits into from
Sep 28, 2021

Conversation

yujonglee
Copy link
Contributor

@yujonglee yujonglee commented Sep 28, 2021

Description

  1. Use yarn install --frozen-lockfile instead of yarn. It looks bit slower(just my feeling), but recommended for CI. It is similar to npm ci.

Screenshot from yarn

스크린샷 2021-09-28 오후 5 01 57

  1. Cache node and cache file of yarn to make process faster.
  2. Replace yarn test:all with yarn test because process is duplicated with previous one such as lerna run build.

Test Plan

none.

Related Issues

none.

Tests

none.

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • Run yarn test:all and make sure nothing fails. You can run yarn test -u to update snapshots if needed.
  • I am willing to follow-up on review comments in a timely manner.

@codecov
Copy link

codecov bot commented Sep 28, 2021

Codecov Report

Merging #132 (f4704de) into master (9e2746d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #132   +/-   ##
=======================================
  Coverage   95.44%   95.44%           
=======================================
  Files          27       27           
  Lines         636      636           
  Branches      280      280           
=======================================
  Hits          607      607           
  Misses         28       28           
  Partials        1        1           

@yujonglee yujonglee requested a review from hyochan September 28, 2021 08:08
@hyochan hyochan added 🍗 enhancement New feature or request 💨 ci Cloud integration labels Sep 28, 2021
Copy link
Owner

@hyochan hyochan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@hyochan hyochan merged commit 0f13552 into hyochan:master Sep 28, 2021
@yujonglee yujonglee deleted the cache branch September 29, 2021 23:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
💨 ci Cloud integration 🍗 enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants