Conversation
Owner
Author
|
the failing mypy check should start passing once GitHub ships 3.14.0b2 (it already works for me locally). |
|
For what it's worth, this CPython change is present in the 3.13 branch, and as such this PR fixes the test against the next 3.13 point release as well. Thank you for the fix! |
Owner
Author
|
huh! thanks for the heads up! I should plan a release then. Not that it would stop people from opening issues anyways. 😅 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The only change necessary is that we can't rely on isEnabledFor anymore, because it returns always False in the way we use it.