TimeStamper now returns UTC timezone for custom format string.#713
Merged
hynek merged 3 commits intohynek:mainfrom Apr 25, 2025
Merged
TimeStamper now returns UTC timezone for custom format string.#713hynek merged 3 commits intohynek:mainfrom
hynek merged 3 commits intohynek:mainfrom
Conversation
Owner
|
Is this true @adamchainz? 😇 |
hynek
approved these changes
Apr 25, 2025
Owner
hynek
left a comment
There was a problem hiding this comment.
hilariously, I just ran into this bug myself.
thanks, will release asap!
Contributor
Author
|
Haha, good to hear it's not only me seeing that ;) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change reverts the ability to display a UTC timestamp with a custom strftime format string in
TimeStamper. Previously, the local time zone was used regardless ofutc=Trueflag for TimeStamper. The output forutc=Falseremains unchanged, and timezone is correctly displayed with%zand%Z.Due to limitations in freezegun, the tests don't simulate execution is different timezones. Maybe a switch to time-machine can fix that.
Feel free to remove comments and descriptions in changelog.
Pull Request Check List
mainbranch – use a separate branch!api.py.docs/api.rstby hand.versionadded,versionchanged, ordeprecateddirectives..rstand.mdfiles is written using semantic newlines.