-
-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DRAFT] Add CallsiteInfoAdder class which populates the event dictionary with callsite info #380
Conversation
I like the approach and I have only two concerns:
|
Thanks for the heads up on these, I will do some testing with async to see what is what, and I will allow user control of |
200a064
to
90d55d2
Compare
d4df105
to
351b1ac
Compare
deleting this PR as I will create a new one from same branch to work around the branch editing issue. |
I know its closed, but what about class if available as well... use case would be to find all of the logging calls in a particular class... You can check if the first arg is self, if it is then get the class and the name of that? |
@gzmarstone Nice to know about this, I will consider adding this - would be nice to have - but will only get time to look at it next year if at all. The main goal was to get parity with capabilities of the stdlib logger regarding callsite info. Update: You could create a logger on a class, named for the class and the module, and then use the logger name. |
No problem, I just noticed the change with the latest release and it would let me delete the code that I had to implemented to log the stdlib items, but then realized that it was missing the Class which I have, so I couldn't delete all of it yet... I can just leave that part in my code and if it gets added obsolete it, otherwise no big deal... |
Summary
This PR creates a CallsiteInfoAdder processor which will populate the event dictionary with callsite info:
Fixes #378
Pull Request Check List
This is just a friendly reminder about the most common mistakes. Please make sure that you tick all boxes. But please read our contribution guide at least once, it will save you unnecessary review cycles!
If an item doesn't apply to your pull request, check it anyway to make it apparent that there's nothing left to do.
typing_examples.py
.docs/api.rst
by hand.versionadded
,versionchanged
, ordeprecated
directives. Find the appropriate next version in our__init__.py
file..rst
files is written using semantic newlines.If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!