Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

twisted: don't encapsulate failures twice #145

Merged
merged 2 commits into from
Nov 15, 2017
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
twisted: run tests with older versions of Twisted
In versions < 17, Failure is not a subclass of BaseException, while it
is in versions > 17.
  • Loading branch information
vincentbernat committed Nov 14, 2017
commit c4e3ecd9de105ccc63504eff3bfd3e84da4f3af0
2 changes: 2 additions & 0 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,8 @@ matrix:
env: TOXENV=py27-colorama
- python: "3.6"
env: TOXENV=py36-colorama
- python: "3.6"
env: TOXENV=py36-oldtwisted


# Meta
Expand Down
6 changes: 3 additions & 3 deletions tox.ini
Original file line number Diff line number Diff line change
@@ -1,19 +1,19 @@
[tox]
envlist = {py27,py34,py35,py36,pypy}-{threads,greenlets},{py27,py36}-colorama,flake8,docs,readme,manifest,coverage-report
envlist = {py27,py34,py35,py36,pypy}-{threads,greenlets},{py27,py36}-{colorama,oldtwisted},flake8,docs,readme,manifest,coverage-report


[testenv]
deps =
-rdev-requirements.txt
greenlets: greenlet
twisted
threads,greenlets,colorama: twisted
oldtwisted: twisted < 17
colorama: colorama
py36: python-rapidjson
setenv =
PYTHONHASHSEED = 0
commands = coverage run --parallel -m pytest {posargs}


[testenv:flake8]
basepython = python3.6
skip_install = true
Expand Down