Skip to content

Commit

Permalink
[CRD iOS] Add enum string name for OS::OTHER
Browse files Browse the repository at this point in the history
We got some crash reports happened when the user tries to send a
feedback during a session. Looks like their host os is OTHER, which is
not mapped to a string and crashes the app.

It's unsure when will the host OS be OTHER. Let's just add back the
mapping for now.

Bug: 831956
Change-Id: I2bf285955a266ab61aae4dfc525b5185546c9109
Reviewed-on: https://chromium-review.googlesource.com/1010969
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550355}
  • Loading branch information
ywh233 authored and Commit Bot committed Apr 12, 2018
1 parent b41b27d commit f55e65e
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions remoting/base/chromoting_event.cc
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@ const NameMapElement<ChromotingEvent::Os> kOsNames[] = {
{ChromotingEvent::Os::CHROMOTING_CHROMEOS, "chromeos"},
{ChromotingEvent::Os::CHROMOTING_MAC, "mac"},
{ChromotingEvent::Os::CHROMOTING_WINDOWS, "windows"},
{ChromotingEvent::Os::OTHER, "other"},
{ChromotingEvent::Os::CHROMOTING_ANDROID, "android"},
{ChromotingEvent::Os::CHROMOTING_IOS, "ios"},
};
Expand Down

0 comments on commit f55e65e

Please sign in to comment.