Skip to content

Commit

Permalink
Disable zlib compression in Blimp until crbug.com/637376 fixed.
Browse files Browse the repository at this point in the history
There is a compiler/code optimization bug in zlib's SIMD implementation,
which will take time to investigate and fix. This CL restores
functionality in Blimp by disabling compression.

This CL can be rolled back once the root cause of crbug.com/637736
is addressed.

R=lethalantidote@chromium.org
CC=wez@chromium.org
BUG=637376

Review-Url: https://codereview.chromium.org/2248943003
Cr-Commit-Position: refs/heads/master@{#412346}
  • Loading branch information
kmarshall authored and Commit bot committed Aug 16, 2016
1 parent c1d331a commit f003975
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions blimp/net/stream_socket_connection.cc
Original file line number Diff line number Diff line change
Expand Up @@ -14,12 +14,12 @@

namespace blimp {

// TODO(kmarshall): Re-enable CompressedPacket(Reader|Writer)
// after zlib bug in crbug.com/r637376 is resolved.
StreamSocketConnection::StreamSocketConnection(
std::unique_ptr<net::StreamSocket> socket)
: BlimpConnection(base::MakeUnique<CompressedPacketReader>(
base::MakeUnique<StreamPacketReader>(socket.get())),
base::MakeUnique<CompressedPacketWriter>(
base::MakeUnique<StreamPacketWriter>(socket.get()))),
: BlimpConnection(base::MakeUnique<StreamPacketReader>(socket.get()),
base::MakeUnique<StreamPacketWriter>(socket.get())),
socket_(std::move(socket)) {
DCHECK(socket_);
}
Expand Down

0 comments on commit f003975

Please sign in to comment.