Skip to content

Commit

Permalink
Made cr-dialog-frame not focused by Tab key.
Browse files Browse the repository at this point in the history
In the situation of pressing the Tab key repeatedly, when cr-dialog-frame has
focus, it looks like focus is disappeared.  This CL change the tabIndex assigned
to cr-dialog-frame from 0 to -1. Elements that have negative tabIndex can be
focused but are not traversed by Tab key.

BUG=239306
TEST=manually

Review URL: https://chromiumcodereview.appspot.com/16123002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205482 0039d316-1c4b-4281-b951-d872f2087c98
  • Loading branch information
hirono@chromium.org committed Jun 11, 2013
1 parent 7e40b5c commit efadf73
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion ui/webui/resources/js/cr/ui/dialogs.js
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,9 @@ cr.define('cr.ui.dialogs', function() {

this.frame_ = doc.createElement('div');
this.frame_.className = 'cr-dialog-frame';
this.frame_.tabIndex = 0;
// Elements that have negative tabIndex can be focused but are not traversed
// by Tab key.
this.frame_.tabIndex = -1;
this.container_.appendChild(this.frame_);

this.title_ = doc.createElement('div');
Expand Down

0 comments on commit efadf73

Please sign in to comment.