Minor clean up for RefCountedThreadSafeBase

* Remove unneeded const_cast in the HasOneRef. * Move initial values of members to the declaration. Review-Url: https://codereview.chromium.org/2723403003 Cr-Commit-Position: refs/heads/master@{#454335}
hylschwy · Mar 2, 2017 · e3e3bda · e3e3bda
1 parent dd7a3b8
commit e3e3bda
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 9 deletions.
diff --git a/base/memory/ref_counted.cc b/base/memory/ref_counted.cc
@@ -10,15 +10,10 @@ namespace base {
 namespace subtle {
 
 bool RefCountedThreadSafeBase::HasOneRef() const {
-  return AtomicRefCountIsOne(
-      &const_cast<RefCountedThreadSafeBase*>(this)->ref_count_);
+  return AtomicRefCountIsOne(&ref_count_);
 }
 
-RefCountedThreadSafeBase::RefCountedThreadSafeBase() : ref_count_(0) {
-#if DCHECK_IS_ON()
-  in_dtor_ = false;
-#endif
-}
+RefCountedThreadSafeBase::RefCountedThreadSafeBase() = default;
 
 RefCountedThreadSafeBase::~RefCountedThreadSafeBase() {
 #if DCHECK_IS_ON()

diff --git a/base/memory/ref_counted.h b/base/memory/ref_counted.h
@@ -97,9 +97,9 @@ class BASE_EXPORT RefCountedThreadSafeBase {
   bool Release() const;
 
  private:
-  mutable AtomicRefCount ref_count_;
+  mutable AtomicRefCount ref_count_ = 0;
 #if DCHECK_IS_ON()
-  mutable bool in_dtor_;
+  mutable bool in_dtor_ = false;
 #endif
 
   DISALLOW_COPY_AND_ASSIGN(RefCountedThreadSafeBase);