Skip to content

Commit

Permalink
Add libc++ __tree to ubsan blacklist.
Browse files Browse the repository at this point in the history
libc++ __tree is not ubsan clean. It floods compile and run steps
with "runtime error: downcast" and "runtime error: upcast" errors,
making ubsan much less usable.
This is a KI with libc++: https://llvm.org/bugs/show_bug.cgi?id=19302

Review-Url: https://codereview.chromium.org/2109663003
Cr-Commit-Position: refs/heads/master@{#402902}
  • Loading branch information
mbjorge authored and Commit bot committed Jun 29, 2016
1 parent dbd9f21 commit e2abe23
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions tools/ubsan/blacklist.txt
Original file line number Diff line number Diff line change
Expand Up @@ -69,3 +69,9 @@ fun:*re2*RegexpD*
#############################################################################
# Harmless float division by zero.
fun:*RendererFrameManager*CullUnlockedFrames*

#############################################################################
# libc++ __tree and map are not UBSAN clean
# https://llvm.org/bugs/show_bug.cgi?id=19302
src:*/third_party/libc\+\+/trunk/include/__tree
src:*/third_party/libc\+\+/trunk/include/map

0 comments on commit e2abe23

Please sign in to comment.